I'm starting to suspect that the script I used has bugs, as some of the files are autogenerated (IIRC)...

(or was not meant to cover all these cases)

@plamut it looks like the Owlbot Post Processor check isn't configured for this repo, either. @parthea can you please investigate?

Putting this on hold until we investigate.

I've added the owlbot:run label. Usually this step isn't required. For example, see googleapis/python-datastream#17

Hi @plamut, please let me know if you have any questions.

@parthea I cannot see anything else besides "successfully ran 10 steps" - what does the OwlBot check check?

The most useful information, if supported, would be a warning if any of the files changed in the PR would be overwritten the next time OwlBot runs.

Is this possible or does one have to manually run the code generation locally manually and inspect the diff?

@plamut Owlbot actually did roll back some of your changes in f610443, which is the confirmation that you need to add replacements to owlbot.py: if you push just that change, without touching the other files, then Owlbot will apply it.

@plamut Owlbot actually did roll back some of your changes in f610443, which is the confirmation that you need to add replacements to owlbot.py: if you push just that change, without touching the other files, then Owlbot will apply it.

Ah, didn't see that commit initially when I cam back, it'ss exactly what I needed. 👍 It's clear what gets overridden without the replacement rules.

@tseaver It appears that if OwlBot doesn't doesn't generate any diff, it doesn't add any commits to the PR branch?

(or why was the owlbot:run label re-applied, if the reason was not the "missing" commit?)

Edit: Ah, some the files were not re-generated after all...

Hm... where are the Samples CI checks? (Lint, Python3.6 - 3.8)

@anguillanneuf IIRC you added those checks, is perhaps the master branch hardcoded somewhere and thus they didn't run on a PR to main?

Update: It's fine for now since this PR's target has been changed to master, and we'll then just rename master to main. We should still keep an eye if all the CI checks are preserved even after the rename.

Should be good now, the only change the OwlBot Postprocessor did was a trivial blacken thingy (opted to append a comma to the tuple items).

@parthea Please now rename master to main in the repo settings, thanks!