test: use assertIsInstance where possible (#57)

larkee · web-flow · commit df199f7419ab · 2020-04-17T13:10:56.000+10:00
Co-authored-by: larkee &lt;larkee@users.noreply.github.com&gt;
diff --git a/tests/unit/test_backup.py b/tests/unit/test_backup.py
@@ -120,7 +120,7 @@ def test_from_pb_success(self):
 
         backup = backup_class.from_pb(backup_pb, instance)
 
-        self.assertTrue(isinstance(backup, backup_class))
+        self.assertIsInstance(backup, backup_class)
         self.assertEqual(backup._instance, instance)
         self.assertEqual(backup.backup_id, self.BACKUP_ID)
         self.assertEqual(backup._database, "")
diff --git a/tests/unit/test_client.py b/tests/unit/test_client.py
@@ -459,7 +459,7 @@ def test_instance_factory_defaults(self):
 
         instance = client.instance(self.INSTANCE_ID)
 
-        self.assertTrue(isinstance(instance, Instance))
+        self.assertIsInstance(instance, Instance)
         self.assertEqual(instance.instance_id, self.INSTANCE_ID)
         self.assertIsNone(instance.configuration_name)
         self.assertEqual(instance.display_name, self.INSTANCE_ID)
@@ -479,7 +479,7 @@ def test_instance_factory_explicit(self):
             node_count=self.NODE_COUNT,
         )
 
-        self.assertTrue(isinstance(instance, Instance))
+        self.assertIsInstance(instance, Instance)
         self.assertEqual(instance.instance_id, self.INSTANCE_ID)
         self.assertEqual(instance.configuration_name, self.CONFIGURATION_NAME)
         self.assertEqual(instance.display_name, self.DISPLAY_NAME)
diff --git a/tests/unit/test_database.py b/tests/unit/test_database.py
@@ -198,7 +198,7 @@ def test_from_pb_success_w_explicit_pool(self):
 
         database = klass.from_pb(database_pb, instance, pool=pool)
 
-        self.assertTrue(isinstance(database, klass))
+        self.assertIsInstance(database, klass)
         self.assertEqual(database._instance, instance)
         self.assertEqual(database.database_id, self.DATABASE_ID)
         self.assertIs(database._pool, pool)
@@ -218,7 +218,7 @@ def test_from_pb_success_w_hyphen_w_default_pool(self):
 
         database = klass.from_pb(database_pb, instance)
 
-        self.assertTrue(isinstance(database, klass))
+        self.assertIsInstance(database, klass)
         self.assertEqual(database._instance, instance)
         self.assertEqual(database.database_id, DATABASE_ID_HYPHEN)
         self.assertIsInstance(database._pool, BurstyPool)
@@ -1074,7 +1074,7 @@ def test_session_factory_defaults(self):
 
         session = database.session()
 
-        self.assertTrue(isinstance(session, Session))
+        self.assertIsInstance(session, Session)
         self.assertIs(session.session_id, None)
         self.assertIs(session._database, database)
         self.assertEqual(session.labels, {})
@@ -1090,7 +1090,7 @@ def test_session_factory_w_labels(self):
 
         session = database.session(labels=labels)
 
-        self.assertTrue(isinstance(session, Session))
+        self.assertIsInstance(session, Session)
         self.assertIs(session.session_id, None)
         self.assertIs(session._database, database)
         self.assertEqual(session.labels, labels)
diff --git a/tests/unit/test_instance.py b/tests/unit/test_instance.py
@@ -159,7 +159,7 @@ def test_from_pb_success(self):
 
         klass = self._getTargetClass()
         instance = klass.from_pb(instance_pb, client)
-        self.assertTrue(isinstance(instance, klass))
+        self.assertIsInstance(instance, klass)
         self.assertEqual(instance._client, client)
         self.assertEqual(instance.instance_id, self.INSTANCE_ID)
         self.assertEqual(instance.configuration_name, self.CONFIG_NAME)
@@ -469,7 +469,7 @@ def test_database_factory_defaults(self):
 
         database = instance.database(DATABASE_ID)
 
-        self.assertTrue(isinstance(database, Database))
+        self.assertIsInstance(database, Database)
         self.assertEqual(database.database_id, DATABASE_ID)
         self.assertIs(database._instance, instance)
         self.assertEqual(list(database.ddl_statements), [])
@@ -490,7 +490,7 @@ def test_database_factory_explicit(self):
             DATABASE_ID, ddl_statements=DDL_STATEMENTS, pool=pool
         )
 
-        self.assertTrue(isinstance(database, Database))
+        self.assertIsInstance(database, Database)
         self.assertEqual(database.database_id, DATABASE_ID)
         self.assertIs(database._instance, instance)
         self.assertEqual(list(database.ddl_statements), DDL_STATEMENTS)
