Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test: use assertIsInstance where possible #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2020
Merged

test: use assertIsInstance where possible #57

merged 2 commits into from
Apr 17, 2020

Conversation

larkee
Copy link
Contributor

@larkee larkee commented Apr 16, 2020

Using the self.assertIsInstance(..., ...) method will give more detailed error information than self.assertTrue(isinstance(..., ...))

@larkee larkee requested a review from hengfengli April 16, 2020 23:39
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 16, 2020
@larkee larkee changed the title test: use testIsInstance where possible test: use assertIsInstance where possible Apr 17, 2020
hengfengli
hengfengli approved these changes Apr 17, 2020
View reviewed changes
Copy link

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@larkee larkee merged commit df199f7 into googleapis:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hengfengli hengfengli hengfengli approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@larkee @hengfengli @googlebot