Thanks to visit codestin.com
Credit goes to github.com

Skip to content

build: ensure tracing dependencies are installed for tests #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2020
Merged

build: ensure tracing dependencies are installed for tests #134

merged 2 commits into from
Aug 21, 2020

Conversation

larkee
Copy link
Contributor

@larkee larkee commented Aug 18, 2020

In #133, the tracing dependencies were move to extra requirements in the setup.py. These are not installed by default. This updates noxfile.py so that the tracing requirements are installed when running tests.

@larkee larkee added the api: spanner Issues related to the googleapis/python-spanner API. label Aug 18, 2020
@larkee larkee requested a review from hengfengli August 18, 2020 07:10
@larkee larkee requested a review from a team as a code owner August 18, 2020 07:10
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 18, 2020
@larkee larkee changed the title Pin dependency build: ensure tracing dependencies are installed for tests Aug 18, 2020
hengfengli
hengfengli approved these changes Aug 18, 2020
View reviewed changes
Copy link

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 19, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 19, 2020
@larkee larkee merged commit 1513e7e into googleapis:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hengfengli hengfengli hengfengli approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@larkee @hengfengli @yoshi-kokoro