Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

larkee
Copy link
Contributor

@larkee larkee commented Mar 23, 2020

Closes #41

@larkee larkee requested a review from IlyaFaer March 23, 2020 05:28
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 23, 2020
@IlyaFaer
Copy link
Contributor

Unfortunately it makes changes to a generated file

I suppose, it would be good to add a disclaimer into the generated files. Something like Generated file. Do not edit!, otherwise it's not very obvious, unless you know what is gapic and expect to meet generated files.

As they are doing this in other clients, I (for example) have a habit to check if this line is in the file: if not, consider file isn't generated.

@larkee
Copy link
Contributor Author

larkee commented Mar 24, 2020

I suppose, it would be good to add a disclaimer into the generated files. Something like Generated file. Do not edit!, otherwise it's not very obvious, unless you know what is gapic and expect to meet generated files.

As they are doing this in other clients, I (for example) have a habit to check if this line is in the file: if not, consider file isn't generated.

That makes sense. I think I have seen that in some of the other generated files. I'm not sure why it has been removed from these ones. I'll mention it to the generator team.

@larkee larkee merged commit cd822c9 into googleapis:master Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect return type in update_database_ddl() docs
3 participants