docs(spanner): changes to support sphinx new release #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@larkee Please let me know could i make changes for docs/gapic/*.rst files manually? |
|
Good news! Those files aren't generated so this PR looks good to me :) I understand the confusion. I had to run the synthtool to confirm. I suspect the reason these files are in folder named gapic is to match the folder structure of the files they're generating documentation for. |
larkee
approved these changes
Apr 14, 2020
larkee
reviewed
Apr 14, 2020
larkee
reviewed
Apr 14, 2020
larkee
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50
Hope this Draft PR helps to fix issue quickly.
.rstfiles changes which i can't address so can't open Public PR, but changed that gapic.rstfiles for just references.