Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: make it clear ddl_statements is a list in docs #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2020
Merged

docs: make it clear ddl_statements is a list in docs #59

merged 1 commit into from
Apr 28, 2020

Conversation

bpg130
Copy link
Contributor

@bpg130 bpg130 commented Apr 17, 2020

The ddl_statements fields expects a list of strings, not a string. This aims to make that more clear in the documentation.

If it is required that I open a bug for doc changes let me know and I will be happy to do so!

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 17, 2020
@bpg130 bpg130 changed the title Make it clear ddl_statements is a list in docs docs: make it clear ddl_statements is a list in docs Apr 17, 2020
larkee
larkee approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is fairly minimal and straightforward so I think no bug is fine. LGTM but please run git commit --amend and edit your message to match Conventional Commit guidelines. Matching the title of this PR should work.

@bpg130
docs: make it clear ddl_statements is a list in docs
58a0f25 
The ddl_statements fields expects a list of strings, not a string. This aims to make that more clear in the documentation.
@bpg130
Copy link
Contributor Author

bpg130 commented Apr 24, 2020

Thanks larkee, I have updated the commit message.

@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 27, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 27, 2020
@bcoe bcoe added cla: yes This human has signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Apr 28, 2020
@larkee larkee merged commit d63dcb6 into googleapis:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkee larkee larkee approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bpg130 @larkee @bcoe @googlebot @yoshi-kokoro