fix(deps): require google-api-core >= 1.31.5, >= 2.3.2 on v2 release #688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthea
approved these changes
Mar 13, 2022
|
It looks like CODEOWNERS enforcement comes from the branch the changes are being made to. On main, the latest https://github.com/googleapis/python-spanner/blob/main/.github/CODEOWNERS allows approval from yoshi-python or api-spanner. Merging since I've obtained approval from @parthea in yoshi-python. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow google-api-core<3.0.0dev on previous release of library. Note that this PR is to a new protected branch v2, not main.
This will be followed by a release PR and is a step towards removing googleapis/google-cloud-python#10566