Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

larkee
Copy link
Contributor

@larkee larkee commented Apr 27, 2020

No description provided.

@larkee larkee requested review from hengfengli and skuruppu April 27, 2020 22:52
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 27, 2020
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 28, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 28, 2020
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 28, 2020
Copy link
Contributor

@skuruppu skuruppu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But as we've been finding for other languages, you'll find that these tests will often timeout during the backup creation or restore part. So it would be good to reduce the number of create and restore calls. E.g. I think I never added a restore to different instance test in Node.js.

You can also save time by not waiting for the optimize. You can do:

  1. Wait for restore to complete.
  2. Delete restored database.
  3. Delete backup.
    It's faster this way and you don't get a FAILED_PRECONDITION error when you're trying to delete the backup.

@larkee larkee removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 29, 2020
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 4, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 4, 2020
@larkee
Copy link
Contributor Author

larkee commented May 5, 2020

Looks good. But as we've been finding for other languages, you'll find that these tests will often timeout during the backup creation or restore part. So it would be good to reduce the number of create and restore calls. E.g. I think I never added a restore to different instance test in Node.js.

I haven't run into any timeouts recently so I'm okay with keeping the different instance restore.

You can also save time by not waiting for the optimize. You can do:

  1. Wait for restore to complete.
  2. Delete restored database.
  3. Delete backup.
    It's faster this way and you don't get a FAILED_PRECONDITION error when you're trying to delete the backup.

Done 👍 This also fixed a flaky test!

@larkee larkee merged commit b7739da into googleapis:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants