feat: Stage 6 of nox implementation - enabling system tests
#480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nox implementation - enabling system testsnox implementation - enabling system tests
busunkim96
reviewed
Sep 3, 2020
noxfile.py
Outdated
| # virtualenv's dist-packages. | ||
| session.install("mock", "pytest") | ||
| session.install("-e", ".") | ||
| session.install("-e", "test_utils") |
There was a problem hiding this comment.
If any of the system tests need the contents of test_utils, you can install it through pip.
It might not be necessary though (there's not too much in it (https://github.com/googleapis/python-test-utils/tree/master/test_utils) at this point.
pip install google-cloud-testutils
There was a problem hiding this comment.
@busunkim96 👍 Agreed. This way used to be prevalent across other products and still exists in Spanner, Bigtable, and possibly some others. Would it be a good idea to update those as well?
c24t
reviewed
Sep 8, 2020
c24t
approved these changes
Sep 8, 2020
This was referenced Sep 10, 2020
c24t
pushed a commit
that referenced
this pull request
Sep 15, 2020
Add googleapis/python-test-utils and system test stub
This was referenced Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #466 , this represents the last item of the recommended list aimed to implement nox testing automation in multiple steps.
Change list:
test_utilspackage directory;systemtest session to Nox configuration;tests/system/test_system.pytemplate file;.gitignorefile.A dummy test method inside the template file is necessary to avoid an
exit code 5error, that is when no tests get collected.Session test log:
Towards #474.