Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: verify and comment the DB API exceptions #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 6, 2020
Merged

refactor: verify and comment the DB API exceptions #522

merged 4 commits into from
Oct 6, 2020

Conversation

IlyaFaer
Copy link
Contributor

No description provided.

@IlyaFaer IlyaFaer added type: process A process-related concern. May include testing, release, or the like. api: spanner Issues related to the googleapis/python-spanner-django API. labels Sep 30, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 30, 2020
@IlyaFaer IlyaFaer requested review from c24t and mf2199 September 30, 2020 08:16
@IlyaFaer IlyaFaer marked this pull request as ready for review September 30, 2020 08:16
@IlyaFaer IlyaFaer requested a review from a team as a code owner September 30, 2020 08:16
mf2199
mf2199 reviewed Sep 30, 2020
View reviewed changes
Copy link
Contributor

@mf2199 mf2199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments look fine, I'd just rearrange them a bit to get rid of some of the unnecessary line breaks. See the suggested variant here.

@IlyaFaer IlyaFaer requested a review from a team October 6, 2020 08:21
mf2199
mf2199 approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@mf2199 mf2199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little nit, see the comment, but otherwise LGTM.

@IlyaFaer IlyaFaer merged commit 5ed0845 into googleapis:master Oct 6, 2020
@IlyaFaer IlyaFaer deleted the exceptions_update branch October 6, 2020 15:26
This was referenced Apr 17, 2024
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c24t c24t Awaiting requested review from c24t

1 more reviewer

@mf2199 mf2199 mf2199 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. cla: yes This human has signed the Contributor License Agreement. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IlyaFaer @mf2199