Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

@googlebot I signed it!

@c24t Although I am still working on this, shouldn't we add a commitment.config.js to validate commits ?

shouldn't we add a commitment.config.js to validate commits ?

There's a googleapis checker for this, AFAIK this is configured the same way for all repos in the org. You can see the check in action on this PR above.

FYI you can open PRs as drafts if they're WIP and not ready for review: https://github.blog/2019-02-14-introducing-draft-pull-requests/.

Closing as inactive. To fix #485 we need to patch django in tests (or host our own patched version of django), not just s/timgraham/django/.