fix: iexact lookup with Transform expression crash issue when RHS is direct value and a transform function is involved #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: add a Code of Conduct (googleapis#604)
fix: lint_setup_py was failing in Kokoro is now fixed (googleapis#607)
fix: Remove un necessary file from code base (googleapis#608)
feat: move migrations test modules to run against different emulator …
feat: update workflow files to uniformly distribute the test modules …
feat: update docs and nox file to compile it (googleapis#610)
skuruppu
approved these changes
May 20, 2021
This was referenced Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In iexact match added a check, If rhs is not a direct value and parameter is not present we want to have only 1 format able argument in rhs_sql else we need 2.
this is fix for queries like:
Author.objects.filter(name__upper__iexact="abc").