Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: Update Healthchecks instructions #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 3, 2022
Merged

docs: Update Healthchecks instructions #738

merged 2 commits into from
Jan 3, 2022

Conversation

cuu508
Copy link
Contributor

@cuu508 cuu508 commented Dec 2, 2021

  • remove the note about Django 2.2 being the only supported version (Django 3.2 seems to work too)
  • change the django-google-spanner install instructions to install from PyPI
  • fix Markdown formatting for python code blocks

@cuu508
Update Healthchecks instructions
4e4ed3b 
- remove the note about Django 2.2 being the only supported version
  (3.2 seems to work too)
- change the install instructions to install from PyPI
- fix Markdown formatting for python code blocks
@cuu508 cuu508 requested a review from a team as a code owner December 2, 2021 14:44
@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Dec 2, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-django API. label Dec 2, 2021
@cuu508
Copy link
Contributor Author

cuu508 commented Dec 2, 2021

(just signed CLA)

vi3k6i5
vi3k6i5 approved these changes Dec 31, 2021
View reviewed changes
Copy link
Contributor

@vi3k6i5 vi3k6i5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Dec 31, 2021
@vi3k6i5 vi3k6i5 changed the title Update Healthchecks instructions docs: Update Healthchecks instructions Dec 31, 2021
@vi3k6i5 vi3k6i5 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 3, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 3, 2022
@vi3k6i5 vi3k6i5 merged commit 6a83e12 into googleapis:main Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@vi3k6i5 vi3k6i5 vi3k6i5 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cuu508 @vi3k6i5 @yoshi-kokoro