feat!: Support Django 4.2 #865

ankiaga · 2024-04-12T04:57:59Z

Breaking changes

Removes support for Django 2.2
Transaction handling in Django 4.2 is different than in Django 3.2:
- In Django 3.2: When Django tries to manually start a transaction while the dbapi connection is in AutoCommit=True mode, the Spanner Django provider would not start a transaction.
- In Django 4.2: When Django wants to manually start a transaction while the dbapi connection is in AutoCommit=True mode, the Spanner Django provider will start a transaction.

Release notes

Adds support for Django 4.2
Removes support for Django 2.2
Only Python versions 3.8 and higher are supported
Adds support for transactions in AutoCommit=True mode by default for V4.2. Transactions in AutoCommit=True mode are by default not supported in prior versions (i.e. V3.2).
- To enable manual transactions in AutoCommit=True mode in V3.2, please set ALLOW_TRANSACTIONS_IN_AUTO_COMMIT=True your settings.py file.
- To disable transactions in AutoCommit=True mode in V4.2, please set ALLOW_TRANSACTIONS_IN_AUTO_COMMIT=False in your settings.py file.

django_spanner/compiler.py

jaz-la · 2024-04-15T21:28:37Z

django_spanner/__init__.py

-    )
-    from django.db.models import JSONField
+USING_DJANGO_4 = False
+if django.VERSION[:2] == (4, 2):


as commented in this draft:
#860 (comment)

Currently Django 5 is released, since you are already working on it, can this field be override with a system environment, and make it something like:
if django.VERSION[:2] == (4, 2) or os.getenv('USING_DJANGO_4', 'false') == 'true'

Sorry we cant do that as we are not sure how will Django 5 behave with this code.
Please feel free to create a fork and make changes

Can I second @jaz-la's request? If we can appropriately set expectations with the env car, what's the harm? I am currently using a fork that is hard to maintain with Django 5, and this PR includes everything that I have needed for Django 5 so far. Please?

Thanks again for all of your work.

django_spanner/__init__.py

django_spanner/schema.py

tests/unit/django_spanner/test_compiler.py

django_spanner/__init__.py

jaz-la · 2024-04-15T21:48:42Z

thanks a lot for working on it, left a few comments.
I'm hoping that we can also have a way to bypass the version check and fall into Django 4 logic with Django 5 at our own risk.
Another suggestion is to add a summary in the PR description so new developers can understand the actual difference between django 3 vs 4 without digging into the code.

README.rst

django_spanner/__init__.py

django_spanner/base.py

django_spanner/compiler.py

django_test_suite_4.2.sh

noxfile.py

tests/unit/django_spanner/test_operations.py

jaz-la

thank you for working on it, I have been wanting to upgrade my django version for a long time and this is the last library that blocks me from doing so.

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Knut Olav Løite <[email protected]>

product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-django API. label Apr 12, 2024

ankiaga requested a review from olavloite April 12, 2024 05:32