tests: remove editable install in tests #383
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@parthea Can we please get this PR merged? |
|
@ankiaga This PR is ready for review. PTAL |
ankiaga
approved these changes
Jan 22, 2024
|
@parthea I have included these changes in #384 as we couldn't merge this PR because of existing test failures. I could also not merge my PR (to fix tests) without these change after latest release of python-spanner repo so both the changes have been included in #384 and we can close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are limitations for editable installations, and this type of installation is still listed as experimental on pypa.io:
https://setuptools.pypa.io/en/latest/userguide/development_mode.html#limitations
As a longer term fix, we may be able to improve support for editable installations by switching to a src layout instead of a flat layout.
googleapis/google-cloud-python#12078