-
Notifications
You must be signed in to change notification settings - Fork 159
fix: allow Protobuf 6.x #1445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow Protobuf 6.x #1445
Conversation
|
|
Python 3.13
|
The issue is that wheels aren't published for |
ff373da
to
457db16
Compare
@cojenco, Please could you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
CURRENT_DIRECTORY = pathlib.Path(__file__).parent.absolute() | ||
|
||
# Error if a python version is missing | ||
nox.options.error_on_missing_interpreters = True | ||
|
||
nox.options.sessions = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC this is setting a list of sessions to run by default (to exclude prerelease_deps
so that it is only ran in kokoro prerelease_deps)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is correct. Also see https://nox.thea.codes/en/stable/tutorial.html#selecting-which-sessions-to-run
env_vars: { | ||
key: "SECRET_MANAGER_KEYS" | ||
value: "client-library-test-universe-domain-credential" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we've considered running prerelease-deps
in continuous instead of presubmits. This increases presubmit running time and the extra two runs of the system test suite are more prone to 429 errors and server-side resource overload etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in cl/738167833 and 77a3dc8
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
See https://pypi.org/project/protobuf/6.30.0/
See googleapis/gapic-generator-python#2347 for removing
dev
insetup.py
Wait for googleapis/gapic-generator-python#2352, googleapis/python-api-core#804, googleapis/proto-plus-python#536BEGIN_COMMIT_OVERRIDE
fix: add trove classifier for Python 3.13
fix: resolve issue where pre-release versions of dependencies are installed
fix(deps): require protobuf >= 3.20.2, < 7.0.0
fix(deps): require google-crc32c >= 1.1.3
fix(deps): require requests >= 2.22.0
tests: add tests for Python 3.13
tests: add pre-release testing via
prerelease_deps
nox sessiontests(samples): add configuration for python 3.13
tests: add constraints file to test the minimum supported version of a dependency
END_COMMIT_OVERRIDE