Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Fix BlobReader handling of interleaved reads and seeks #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 11, 2022
Merged

fix: Fix BlobReader handling of interleaved reads and seeks #721

merged 3 commits into from
Mar 11, 2022

Conversation

aabbccddeeffgghhii1438
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #462 🦕

@aabbccddeeffgghhii1438 aabbccddeeffgghhii1438 requested review from a team as code owners March 2, 2022 00:18
@google-cla
Copy link

google-cla bot commented Mar 2, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Mar 2, 2022
@andrewsg andrewsg self-assigned this Mar 11, 2022
andrewsg
andrewsg requested changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your valuable contribution and especially for adding the test. I can see the problem was due to an inconsistent usage of reader._pos between the read and seek methods. I have one suggestion, which will fix the DeprecationWarnings in pytest output.

@andrewsg andrewsg changed the title Patch reader seek fix: Fix BlobReader handling of interleaved reads and seeks Mar 11, 2022
andrewsg
andrewsg approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Will merge once system tests are complete.

@andrewsg andrewsg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 11, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 11, 2022
@andrewsg andrewsg merged commit 5d1cfd2 into googleapis:main Mar 11, 2022
@release-please release-please bot mentioned this pull request Mar 11, 2022
Merged
@aabbccddeeffgghhii1438 aabbccddeeffgghhii1438 deleted the patch_reader_seek branch March 11, 2022 05:58
@release-please release-please bot mentioned this pull request Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsg andrewsg andrewsg approved these changes

Assignees

@andrewsg andrewsg

Labels
api: storage Issues related to the googleapis/python-storage API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BlobReader not buffering properly.
3 participants
@aabbccddeeffgghhii1438 @andrewsg @yoshi-kokoro