test: skip tests if the required packages are not installed #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ae67dee to
ebba1c8
Compare
vchudnov-g
approved these changes
Jul 19, 2024
| @@ -34,9 +41,19 @@ | |||
| BAD_PACKAGE = "invalid-package" | |||
|
|
|||
|
|
|||
| def skip_test_if_not_installed(package_name: str): | |||
There was a problem hiding this comment.
Style note: this could be a decorator for each test function, and pass the package name to the test function, so we only hard-code it once.
Not a blocker by any means.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the snippet below, tests in
test_lower_bound_checker.pyrequire that specific packages intests/unit/resourcesbe installed in the same environment. If those packages don't exist during test time, we should mark the test as skipped.python-test-utils/tests/unit/test_lower_bound_checker.py
Lines 31 to 34 in 24e6347
Fixes #168 🦕