chore: updating release-please versions in WORKSPACE #1220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakeli0
reviewed
Jan 6, 2023
WORKSPACE
Outdated
| repositories = ["https://repo.maven.apache.org/maven2/"], | ||
| ) | ||
|
|
||
| <!--- {x-version-update-start:gapic-generator-java:released} --> |
There was a problem hiding this comment.
This comment style is for xmls only and it may not work for WORKSPACE
There was a problem hiding this comment.
It works for a README.md file, so let's see if it works here as well. And this annotation is not for inline version updates like we do in xml files, this is a block update.
There was a problem hiding this comment.
The build failed with syntax error.
(17:48:47) ERROR: /home/runner/work/gapic-generator-java/gapic-generator-java/WORKSPACE:67:1: syntax error at '<': expected expression
(17:48:47) ERROR: /home/runner/work/gapic-generator-java/gapic-generator-java/WORKSPACE:67:2: invalid character: '!'
(17:48:47) ERROR: /home/runner/work/gapic-generator-java/gapic-generator-java/WORKSPACE:6[9](https://github.com/googleapis/gapic-generator-java/actions/runs/3857289723/jobs/6574513783#step:7:10):2: invalid character: '!'
I've reverted it back to previous annotations. Let's see if these annotations work with specifying "extraFiles" in the yaml config.
|
Kudos, SonarCloud Quality Gate passed!
|
blakeli0
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.