Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: add artifacts in gapic bom in allow list #2402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2024
Merged

chore: add artifacts in gapic bom in allow list #2402

merged 1 commit into from
Jan 19, 2024

Conversation

JoeWang1127
Copy link
Collaborator

In this PR:

  • Add artifacts in gapic-bom to the allow list of unmanaged dependency check
    • com.google.api.grpc:gapic-google-*
    • com.google.analytics:google-analytics-*
    • com.google.area120:google-area120-*
    • com.google.apis:google-api-*
    • io.grafeas:grafeas

Related check log in google-cloud-java:

Running Unmanaged Dependency Check against /home/runner/work/google-cloud-java/google-cloud-java/gapic-libraries-bom/pom.xml
This pull request seems to add new third-party dependency, [com.google.analytics:google-analytics-data, io.grafeas:grafeas, com.google.apis:google-api-services-cloudresourcemanager, com.google.analytics:google-analytics-admin, com.google.area120:google-area120-tables, com.google.apis:google-api-services-translate, com.google.api.grpc:gapic-google-cloud-storage-v2, com.google.apis:google-api-services-dns, com.google.apis:google-api-services-storage], among the artifacts listed in gapic-libraries-bom/pom.xml.

Full log: https://github.com/googleapis/google-cloud-java/actions/runs/7560283873/job/20669061714?pr=10231

@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

conventional-commit-lint-gcf bot commented Jan 19, 2024 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jan 19, 2024
@JoeWang1127 JoeWang1127 force-pushed the chore/add-allowed-artifacts branch from 8a73331 to beb4b0a Compare January 19, 2024 21:01
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@JoeWang1127 JoeWang1127 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 19, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 19, 2024
@JoeWang1127 JoeWang1127 marked this pull request as ready for review January 19, 2024 21:48
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner January 19, 2024 21:48
@JoeWang1127 JoeWang1127 requested a review from suztomo January 19, 2024 21:49
@JoeWang1127 JoeWang1127 merged commit f22c012 into main Jan 19, 2024
@JoeWang1127 JoeWang1127 deleted the chore/add-allowed-artifacts branch January 19, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo approved these changes

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoeWang1127 @suztomo