ci: validate unmanaged dependency check in a few downstream repositories #2426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
JoeWang1127
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2425
With this validation, we can see whether a change made to UnmanagedDependencyCheck is causing check failure in the downstream repository. When there's a bad change, the check fails with the following message:
With this change, the unmanaged dependencies check installed in java-bigtable will start to fail due to [com.google.api.grpc:grpc-google-cloud-bigtable-admin-v2, com.google.api.grpc:grpc-google-cloud-bigtable-v2, com.google.api.grpc:proto-google-cloud-bigtable-v2, com.google.api.grpc:proto-google-cloud-bigtable-admin-v2], among the artifacts listed in /home/runner/work/sdk-platform-java/sdk-platform-java/java-bigtable/google-cloud-bigtable-bom/pom.xml.