You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes#2423
The root cause of the issue is that logDirectPathMisconfig() is called in the builder of InstantiatingGrpcChannelProvider, which could be called multiple times before it is fully instantiated. We should only call logDirectPathMisconfig() right before createChannel() which creates the first channel.
We can not move it to before createSingleChannel() because it is used for resizing channel regularly after a client is initialized, and we only want to log direct path misconfiguration once.
Thoughts on adding test which creates a InstantiatingGrpcChannelProvider, changes a property in the builder with it still misconfigured, and recreates it? Essentially runs InstantiatingGrpcChannelProvider.{newBuilder|toBuilder()}.build() twice. The FakeLogHandler should only show the misconfiguration log once since the logging should occur prior to channel creation and on .build().
Might be beneficial so we don't accidentally refactor logDirectPathMisconfig() into the channel creation logic in the future.
Thoughts on adding test which creates a InstantiatingGrpcChannelProvider, changes a property in the builder with it still misconfigured, and recreates it? Essentially runs InstantiatingGrpcChannelProvider.{newBuilder|toBuilder()}.build() twice. The FakeLogHandler should only show the misconfiguration log once since the logging should occur prior to channel creation and on .build().
Thanks! Added a test case that calling builder should not log anything.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2423
The root cause of the issue is that
logDirectPathMisconfig()is called in the builder ofInstantiatingGrpcChannelProvider, which could be called multiple times before it is fully instantiated. We should only calllogDirectPathMisconfig()right beforecreateChannel()which creates the first channel.We can not move it to before
createSingleChannel()because it is used for resizing channel regularly after a client is initialized, and we only want to log direct path misconfiguration once.