Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

miraleung
Copy link
Contributor

This will work once this PR is in.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 22, 2020
Copy link
Contributor

@xiaozhenliu-gg5 xiaozhenliu-gg5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@xiaozhenliu-gg5 xiaozhenliu-gg5 self-requested a review September 22, 2020 02:15
@xiaozhenliu-gg5
Copy link
Contributor

xiaozhenliu-gg5 commented Sep 22, 2020

One question when following the development doc, that I cloned the showcase proto and copied them to googleapis/. Since it does not have BUILD.bazel in showcase/v1beta1, so I created a new one and copied the script to it, while I got error like:

/Users/xiaozhenliu/googleapis/google/showcase/v1beta1/BUILD.bazel:1:1: file '@com_google_googleapis_imports//:imports.bzl' does not contain symbol 'java_microgenerator_gapic_assembly_gradle_pkg'

Am I missing something?
Does it work on your side? @summer-ji-eng Thank you both.

@miraleung
Copy link
Contributor Author

The error is because this PR isn't merged yet.


```sh
cp gapic-showcase/schema/google/showcase/v1beta1 googleapis/google/showcase/v1beta
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cp -r gapic-showcase/schema/google/showcase/v1beta1 googleapis/google/showcase/v1beta1

@miraleung miraleung merged commit ffbc759 into master Sep 26, 2020
@miraleung miraleung deleted the miraleung-patch-1 branch September 26, 2020 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants