[ggj][infra][2/5] feat: bazel rules support for integration test #393

xiaozhenliu-gg5 · 2020-10-13T05:55:13Z

Find more details in design doc: go/java-micro-integration-test-infra

Support bazel rules to run integration test against Redis API, which includes 1) code generation by micro-generator 2) compare codegen with goldens in test/integration/goldens/redis.

Run the below command to trigger the integration test, and the test failure (diff between codegen and goldens) can be found directly in test.log

bazel test //test/integration:redis

FAIL: //test/integration:redis (see /usr/local/google/home/xiaozhenliu/.cache/bazel/_bazel_xiaozhenliu/96b19089c047889e0621b0e06e850da1/execroot/gapic_generator_java/bazel-out/k8-fastbuild/testlogs/test/integration/redis/test.log)
Target //test/integration:redis up-to-date:
  bazel-bin/test/integration/diff_output.txt
  bazel-bin/test/integration/check_diff_script.sh
INFO: Elapsed time: 155.658s, Critical Path: 64.83s
INFO: 487 processes: 35 internal, 375 linux-sandbox, 77 worker.
INFO: Build completed, 1 test FAILED, 487 total actions
//test/integration:redis                                                 FAILED in 0.1s
  /usr/local/google/home/xiaozhenliu/.cache/bazel/_bazel_xiaozhenliu/96b19089c047889e0621b0e06e850da1/execroot/gapic_generator_java/bazel-out/k8-fastbuild/testlogs/test/integration/redis/test.log



============= test.log ===============
exec ${PAGER:-/usr/bin/less} "$0" || exit 1
Executing tests from //test/integration:redis
-----------------------------------------------------------------------------
diff codegen_tmp/CloudRedisClient.java test/integration/goldens/redis/CloudRedisClient.java
17,18d16
< package com.google.cloud.redis.v1;
<

…nto add_redis_goldens

…ator-java into add_redis_goldens

rules_bazel/java/java_integration_test.bzl

…nto redis_integration_test

rules_bazel/java/java_integration_test.bzl

xiaozhenliu-gg5 · 2020-10-13T15:33:23Z

When the BUILD_WORKSPACE_DIRECTORY env variable is not present, in which context do you run your command: bazel build, bazel run, bazel test? I believe BUILD_WORKSPACE_DIRECTORY is there only for bazel run.

we use bazel test //test/integration: redis to trigger the integration test of Redis API. More info is in description. Thanks! @vam-google If BUILD_WORKSPACE_DIRECTORY is only for bazel run, then is there an equivalent env that can enable us to have access to the generated diff_output folder?

…nto redis_integration_test

rules_bazel/java/java_integration_test.bzl

…generator-java into redis_integration_test

…393) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.protobuf:protobuf-bom](https://developers.google.com/protocol-buffers/) ([source](https://togithub.com/protocolbuffers/protobuf)) | `3.21.2` -> `3.21.3` | [![age](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.21.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.21.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.21.3/compatibility-slim/3.21.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.21.3/confidence-slim/3.21.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>protocolbuffers/protobuf</summary> ### [`v3.21.3`](https://togithub.com/protocolbuffers/protobuf/compare/v3.21.2...v3.21.3) [Compare Source](https://togithub.com/protocolbuffers/protobuf/compare/v3.21.2...v3.21.3) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-common-protos).

…393) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.protobuf:protobuf-java](https://developers.google.com/protocol-buffers/) ([source](https://togithub.com/protocolbuffers/protobuf)) | `3.21.3` -> `3.21.4` | [![age](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-java/3.21.4/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-java/3.21.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-java/3.21.4/compatibility-slim/3.21.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-java/3.21.4/confidence-slim/3.21.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-iam).

xiaozhenliu-gg5 added 18 commits October 8, 2020 21:20

add goldens files for redis client lib

9ad33d2

add bazel file

20a548a

format

cad27bb

Merge branch 'master' into add_redis_goldens

0b740d5

Merge branch 'master' of github.com:googleapis/gapic-generator-java i…

589841a

…nto add_redis_goldens

add todo comment for Redis client lib goldens

8e1edfb

Merge branch 'add_redis_goldens' of github.com:googleapis/gapic-gener…

59d9eb1

…ator-java into add_redis_goldens

add README to integration test goldens folder

5477463

Merge branch 'master' into add_redis_goldens

5de4d5a

Merge branch 'master' into add_redis_goldens

3ec0803

Merge branch 'master' into add_redis_goldens

8ef95c7

Merge branch 'master' into add_redis_goldens

a7659fb

update redis goldens using micro

d36f040

Merge branch 'add_redis_goldens' of github.com:googleapis/gapic-gener…

bc3f47e

…ator-java into add_redis_goldens

add bazel rules

b38559a

remove package-info

62bdbc9

add bazel rules for integration test

bc43026

take api name as arg

4ae798d

xiaozhenliu-gg5 requested review from miraleung and summer-ji-eng as code owners October 13, 2020 05:55

google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 13, 2020

xiaozhenliu-gg5 requested a review from vam-google October 13, 2020 05:55

xiaozhenliu-gg5 commented Oct 13, 2020

View reviewed changes

rules_bazel/java/java_integration_test.bzl Outdated Show resolved Hide resolved

Merge branch 'master' of github.com:googleapis/gapic-generator-java i…

8b97ac2

…nto redis_integration_test

vam-google reviewed Oct 13, 2020

View reviewed changes

rules_bazel/java/java_integration_test.bzl Outdated Show resolved Hide resolved

rules_bazel/java/java_integration_test.bzl Outdated Show resolved Hide resolved

rules_bazel/java/java_integration_test.bzl Outdated Show resolved Hide resolved

xiaozhenliu-gg5 added 3 commits October 13, 2020 15:41

feedback

5e65c2d

Merge branch 'master' into redis_integration_test

c799270

Merge branch 'master' of github.com:googleapis/gapic-generator-java i…

c23d309

…nto redis_integration_test

xiaozhenliu-gg5 requested a review from vam-google October 13, 2020 15:50

miraleung suggested changes Oct 14, 2020

View reviewed changes

xiaozhenliu-gg5 added 5 commits October 14, 2020 17:41

work

658f4b7

Merge branch 'redis_integration_test' of github.com:googleapis/gapic-…

8b79f53

…generator-java into redis_integration_test

emit diff to test.log

cfde217

fix diff command

23154f1

rename

9cf077e

xiaozhenliu-gg5 requested a review from miraleung October 20, 2020 19:38

xiaozhenliu-gg5 added 2 commits October 20, 2020 19:58

add api name to outputs

d59b426

Merge branch 'master' into redis_integration_test

a574038

miraleung approved these changes Oct 21, 2020

View reviewed changes

xiaozhenliu-gg5 merged commit 8992786 into master Oct 21, 2020

xiaozhenliu-gg5 deleted the redis_integration_test branch October 21, 2020 17:37

suztomo pushed a commit that referenced this pull request Mar 21, 2023

deps: update google.core.version to v1.95.4 (#393)

828c3f3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ggj][infra][2/5] feat: bazel rules support for integration test #393

[ggj][infra][2/5] feat: bazel rules support for integration test #393

Uh oh!

xiaozhenliu-gg5 commented Oct 13, 2020 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xiaozhenliu-gg5 commented Oct 13, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

[ggj][infra][2/5] feat: bazel rules support for integration test #393

[ggj][infra][2/5] feat: bazel rules support for integration test #393

Uh oh!

Conversation

xiaozhenliu-gg5 commented Oct 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xiaozhenliu-gg5 commented Oct 13, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xiaozhenliu-gg5 commented Oct 13, 2020 •

edited

Loading