Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[rebase][samplecode] rebase dev_composer and correct samplecode test position #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 6, 2021
Merged

[rebase][samplecode] rebase dev_composer and correct samplecode test position #628

merged 5 commits into from
Jan 6, 2021

Conversation

summer-ji-eng
Copy link
Contributor

@summer-ji-eng summer-ji-eng commented Dec 29, 2020 •
edited
Loading

samplecode-master rebased on dev_composer branch.

This PR is move ServiceClientSampleCodeComposerTest from src/test/.../composer to src/test/.../composer/samplecode.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 29, 2020
@summer-ji-eng summer-ji-eng changed the title Rebase master major change [rebase] rebase latest master major change 12/27 Dec 29, 2020
@summer-ji-eng summer-ji-eng changed the title [rebase] rebase latest master major change 12/27 [rebase] 12/27 rebase latest master major change Dec 29, 2020
miraleung
miraleung suggested changes Dec 29, 2020
View reviewed changes
miraleung
miraleung suggested changes Dec 30, 2020
View reviewed changes
Copy link
Contributor

@miraleung miraleung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we pick this back up after the separate resourcename and default value package changes in master? LGTM on the other diffs ATM.

@summer-ji-eng summer-ji-eng changed the base branch from samplecode-master to master December 30, 2020 23:56
@summer-ji-eng summer-ji-eng changed the base branch from master to samplecode-master December 31, 2020 00:05
@summer-ji-eng summer-ji-eng changed the title [rebase] 12/27 rebase latest master major change [rebase][samplecode] rebase dev_composer and correct samplecode test position Jan 5, 2021
@summer-ji-eng summer-ji-eng merged commit 9c2ad96 into samplecode-master Jan 6, 2021
@summer-ji-eng summer-ji-eng deleted the merge_master branch January 6, 2021 00:45
summer-ji-eng added a commit that referenced this pull request Jan 15, 2021
@summer-ji-eng
[rebase][samplecode] rebase dev_composer and correct samplecode test …
0e32cf4 
…position (#628)

* [samplecode][1/3]Implement Pure Unary RPC sample code (#573)

* [samplecode][1/3]Implement Pure Unary RPC sample code (#573)

* Move ServiceClientSampleCodeComposerTest into correct dir

* rebase #616

* rebase samplecode with dev_composer
suztomo pushed a commit that referenced this pull request Mar 21, 2023
@renovate-bot
deps: update google.core.version to v2.5.10 (#628)
a0458d7
suztomo pushed a commit that referenced this pull request Mar 21, 2023
@release-please
chore: release 2.3.1-SNAPSHOT (#628)
88216ce 
🤖 I have created a release \*beep\* \*boop\*
---
### Updating meta-information for bleeding-edge SNAPSHOT release.
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaozhenliu-gg5 xiaozhenliu-gg5 Awaiting requested review from xiaozhenliu-gg5

1 more reviewer

@miraleung miraleung miraleung approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@summer-ji-eng @miraleung