Fix move excludes #232
Merged
Fix move excludes #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googleapis#48 introduced a bug where the exclude path (which is relative to a tracked path) is compared to a source path (which is relative to the source root). This issue was unnoticed because it works ok when the source path has a single component like in firestore: https://github.com/googleapis/nodejs-firestore/blob/89afae/synth.py#L19 But breaks when the source path has multiple components like in bigtable: https://github.com/googleapis/google-cloud-java/blob/264643/google-cloud-clients/google-cloud-bigtable/synth.py#L30 And when the cwd doesn't match the tracked path
Contributor
Author
|
This is currently blocking: |
busunkim96
approved these changes
Apr 29, 2019
Contributor
Author
|
Thanks for reviewing! Does anything else need to happen for this to be picked up by the next client regen? |
Contributor
|
@igorbernstein2 Autosynth runs synthtool from the master, so nothing else should be necessary. If it's okay to wait the changes should show up on the synth PRs tomorrow morning. (If this needs to go out today we ca re-trigger the Node.js synth job.) Sorry for the delay in reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#48 introduced a bug where the exclude path (which is relative to a tracked path) is compared to a source path (which is relative to the source root).
This issue was unnoticed because it works ok when the source path has a single component like in firestore:
https://github.com/googleapis/nodejs-firestore/blob/89afae/synth.py#L19
But breaks when the source path has multiple components like in bigtable:
https://github.com/googleapis/google-cloud-java/blob/264643/google-cloud-clients/google-cloud-bigtable/synth.py#L30
And when the cwd doesn't match the tracked path