chore(python): skip docfx in main presubmit #889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tswast
requested changes
Jan 5, 2021
synthtool/gcp/templates/python_library/.kokoro/docs/docs-presubmit.cfg
Outdated
Show resolved
Hide resolved
tswast
approved these changes
Jan 8, 2021
Closed
1 task
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 19, 2021
I added this accidentally in #889. `NOX_SESSION` should be passed down if it is set but not marked required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip
docfxsession in the main presubmit (calledKokoro) since it is already covered by the separateKokoro: docs-presubmitcheck in CI.See googleapis/python-bigquery@e68281e and googleapis/python-bigquery#425
Needs change to kokoro configs in 348715194 to allow
NOX_SESSIONenv var in docs-presubmit.