This repository was archived by the owner on Sep 3, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 248
Create a GPU docker container for Datalab. #1367
Merged
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
45c20de
Create a GPU docker container for Datalab.
356a237
Changes based on review comments.
6e80e41
Merge branch 'master' into chmeyers-gpu
chmeyers 168f9b8
Merge branch 'master' into chmeyers-gpu
chmeyers c29876c
Merge branch 'master' into chmeyers-gpu
chmeyers db85fc9
Make the release scripts build/push the GPU image.
de38850
Add GPU to the rollback.
9bdc3c2
Changes based on review comments.
3378a54
Add a create-gpu command to the datalab cli tool.
2dcc67b
Exit cleanly on rollback if there is no previous GPU image.
b2ff692
Merge branch 'master' into chmeyers-gpu
chmeyers 6ae2e75
Updates based on review comments.
77e3acb
Merge branch 'chmeyers-gpu' of github.com:googledatalab/datalab into …
bb97f69
Fix flake8 errors.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Changes based on review comments.
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a note about why we need
--allow-unauthenticated
? (Is it a temporary thing?)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. It's because Ubuntu can't find the keys to the source git repos. Since we only download these for licensing reasons and don't actually use them, I think it's fine. The apt-get installs above are still authenticated.