This repository was archived by the owner on Sep 3, 2022. It is now read-only.
Start the Datalab container using a systemd service #1531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the VMs created by the `datalab` tool to use systemd services for running their containers rather than using a kubelet. This removes one rather large runtime dependency and in my testing this cuts the VM startup time down by more than one minute. This fixes #1373
|
Awesome to see this change... (the removal of large dependency + improvement in startup) |
jimmc
approved these changes
Jul 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the VMs created by the
datalabtoolto use systemd services for running their containers rather
than using a kubelet.
This removes one rather large runtime dependency and in my
testing this cuts the VM startup time down by more than one
minute.
This fixes #1373