This repository was archived by the owner on Sep 3, 2022. It is now read-only.
Disable os-login on newly created instances. #1930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new [os-login feature](https://cloud.google.com/compute/docs/instances/managing-instance-access) is not compatible with the `datalab connect` command. This means that if a user enables os-login for their entire project (as opposed to enabling it for individual instances), then `datalab connect` will stop working (this includes for existing instances). This change works around that issue by explicitly disabling os-login at the instance level at creation time. This fixes #1929
chmeyers
approved these changes
Jan 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new os-login feature
is not compatible with the
datalab connectcommand.This means that if a user enables os-login for their entire project
(as opposed to enabling it for individual instances), then
datalab connectwill stop working (this includes for existinginstances).
This change works around that issue by explicitly disabling os-login
at the instance level at creation time.
This fixes #1929