Add Anchor style to Logo that will take to home #2042
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it! |
|
CLAs look good, thanks! |
| <body> | ||
| <span id="logo" class="nav navbar-brand pull-left"> | ||
| <a id="homeLink"><img id="logoImg" alt="Google Cloud DataLab" style="display:none" /></a> | ||
| <a id="homeLink"><img id="logoImg" alt="Google Cloud DataLab" style="display:none; cursor: pointer;" /></a> |
There was a problem hiding this comment.
Can we add the style to the CSS file instead.
There was a problem hiding this comment.
Sure, I will do that
There was a problem hiding this comment.
@yebrahim Thanks for review. But, in the CSS, there is no Style for id logoImg. so should I create one?
What you linked was for logo ID, so add there or in create new?
There was a problem hiding this comment.
I put a link in my first comment, the line is here:
:)
There was a problem hiding this comment.
The link was for the image. If you add the cursor style there, it'll be applied to the img element under #logo, which is the logoImg, just a different CSS selector.
|
@yebrahim Updated the PR, please review, thanks. :) |
The home logo image did not had anchor style cursor which was difficult to comprehend as end user... So added style to improve that.