This repository was archived by the owner on Sep 3, 2022. It is now read-only.
Added --no-firewall-rule #2135
Merged
Added --no-firewall-rule #2135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll rule on datalab creation.
|
@yebrahim or anyone else on the Datalab team, can we get a review on this? The bug this fixes is stopping us from being able to adopt Datalab. I'm not sure why the CI build is failing, but I think it's unrelated to this change. |
rileyjbauer
previously approved these changes
May 24, 2019
|
@yebrahim, @rileyjbauer, this change has been approved. How long to get it merged? |
rileyjbauer
approved these changes
Jun 4, 2019
rileyjbauer
added a commit
that referenced
this pull request
Jun 4, 2019
This reverts commit 5adb00d.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a new flag --no-firewall-rule which disables firewall rule creation. fixes #2126