Add conductor API to Baremetal V1 #2722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandre
reviewed
Aug 8, 2023
There was a problem hiding this comment.
Hey, thanks for the PR. I had a few nits, mostly on the acceptance tests. The code looks good otherwise.
Could you also change the PR description so that is doesn't say "Fixes #1429" otherwise it's going to close the issue that still has a couple of API calls left to implement.
mandre
reviewed
Aug 8, 2023
mandre
approved these changes
Aug 9, 2023
61 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1429
This commit adds support for the conductor API in Ironic.
Links to the line numbers/files in the OpenStack source code that support the
code in this PR: