Support Firmware Interface #2795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6933922 to
d7d7058
Compare
d7d7058 to
effdfba
Compare
dtantsur
reviewed
Oct 5, 2023
| @@ -404,6 +405,7 @@ const SingleNodeBody = ` | |||
| "driver_internal_info": {}, | |||
| "extra": {}, | |||
| "fault": null, | |||
| "firmwrae_interface": "no-firmware", | |||
There was a problem hiding this comment.
tks! , already updated
effdfba to
0242dd7
Compare
0242dd7 to
f3f9196
Compare
f3f9196 to
1152995
Compare
1152995 to
2bf19c8
Compare
mandre
reviewed
Oct 9, 2023
There was a problem hiding this comment.
Hey @iurygregory, could you rebase your PR on top of master so that we get the bobcat jobs you recently added?
I was curious as to why go-apidiff flags your PR as a breaking change:
github.com/gophercloud/gophercloud/openstack/baremetal/v1/nodes/testing
Incompatible changes:
- NodeListDetailBody: value changed from "\n {\n \"nodes\": [\n {\n \"automated_clean\": null,\n ... to "\n {\n \"nodes\": [\n {\n \"automated_clean\": null,\n ...
- NodeValidationBody: value changed from "\n{\n \"bios\": {\n \"reason\": \"Driver ipmi does not support b... to "\n{\n \"bios\": {\n \"reason\": \"Driver ipmi does not support b...
- SingleNodeBody: value changed from "\n{\n \"automated_clean\": null,\n \"bios_interface\": \"no-bios\"... to "\n{\n \"automated_clean\": null,\n \"bios_interface\": \"no-bios\"...
Compatible changes:
- HandleListFirmwareSuccessfully: added
- NodeFirmwareList: added
- NodeFirmwareListBody: added
github.com/gophercloud/gophercloud/openstack/baremetal/v1/nodes
Compatible changes:
- CreateOpts.FirmwareInterface: added
- FirmwareComponent: added
- InterfaceFirmware: added
- ListFirmware: added
- ListFirmwareResult: added
- Node.FirmwareInterface: added
- NodeValidation.Firmware: added
github.com/gophercloud/gophercloud/openstack/baremetal/v1/drivers/testing
Incompatible changes:
- SingleDriverDetails: value changed from "\n{\n \"default_bios_interface\": \"no-bios\",\n \"default_boot_in... to "\n{\n \"default_bios_interface\": \"no-bios\",\n \"default_boot_in...
github.com/gophercloud/gophercloud/openstack/baremetal/v1/drivers
Compatible changes:
- Driver.DefaultFirmwareInterface: added
- Driver.EnabledFirmwareInterfaces: added
It's because of the changes you made to the fixtures, which we should not consider part of the API. We may need to move that to an internal directory like we did with #2786. While we do that, we can overwrite the label to semver:patch.
Also, it looks like devstack install is broken for ironic on ubuntu 20.04:
Setting up grub-efi-amd64-signed (1.187.6~20.04.1+2.06-2ubuntu14.4) ...
mount: /var/lib/grub/esp: special device /dev/disk/by-id/scsi-14d53465420202020d8446e3f9983954098f1e80336f3baf3-part15 does not exist.
dpkg: error processing package grub-efi-amd64-signed (--configure):
installed grub-efi-amd64-signed package post-installation script subprocess returned error exit status 32
Errors were encountered while processing:
grub-efi-amd64-signed
E: Sub-process /usr/bin/dpkg returned an error code (1)
Is that something you're looking into?
|
@mandre hey, we are looking into it, but I don't think the failure is related to the code change since the same tests failed when I added bobcat jobs see https://github.com/gophercloud/gophercloud/actions/runs/6434009366 |
2bf19c8 to
4cae07c
Compare
4cae07c to
ac919b4
Compare
|
@mandre when you have a chance please take a second look =) Tks! |
mandre
reviewed
Oct 16, 2023
There was a problem hiding this comment.
Apologies, we've merged #2811 that renamed the fixtures files to fixtures_test.go. This is the reason why you're getting a conflict. You'll have to rebase once more and fix the conflict. Sorry about that. But there's a good news too: the bot should no longer flag your PR as a breaking change.
PR looks fine to me otherwise.
* Driver updated to support - default_firmware_interface and enabled_firmware_interfaces * Node updated to support - firmware_interface field can be specified - List the Firmware Components requires API 1.86 Acceptance tests added - show that the node has the field FirmwareInterface and that returns no Firmware Components since is ipmi.
ac919b4 to
8b13ac9
Compare
|
Thanks @mandre I've rebased the PR, let's see how it goes |
mandre
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2794
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
[https://review.opendev.org/c/openstack/ironic/+/885276]
[https://review.opendev.org/c/openstack/ironic/+/885425]
[https://docs.openstack.org/api-ref/baremetal/#node-firmware-nodes]