[glance]: handle various image struct member types #3159
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| package assert | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "strconv" | ||
| ) | ||
|
|
||
| const errf = "unknown type for %s: %T (value: %v)" | ||
|
|
||
| func Int(v any, name string) (int, error) { | ||
|
|
||
| switch t := v.(type) { | ||
| case nil: | ||
| return 0, nil | ||
| case int: | ||
| return t, nil | ||
| case int64: | ||
| return int(t), nil | ||
| case float32: | ||
| return int(t), nil | ||
| case float64: | ||
| return int(t), nil | ||
| case string: | ||
| return strconv.Atoi(t) | ||
| } | ||
|
|
||
| return 0, fmt.Errorf(errf, name, v, v) | ||
| } | ||
|
|
||
| func Int64(v any, name string) (int64, error) { | ||
|
There was a problem hiding this comment. If you made NumberOrString generic on the return type you wouldn't need this function at all. type ConvertibleNumber interface { int | int64 | float32 | float64 } |
||
| switch t := v.(type) { | ||
| case nil: | ||
| return 0, nil | ||
| case int: | ||
| return int64(t), nil | ||
| case int64: | ||
| return t, nil | ||
| case float32: | ||
| return int64(t), nil | ||
| case float64: | ||
| return int64(t), nil | ||
| case string: | ||
| return strconv.ParseInt(t, 10, 64) | ||
| } | ||
|
|
||
| return 0, fmt.Errorf(errf, name, v, v) | ||
| } | ||
|
|
||
| func String(v any, name string) (string, error) { | ||
|
There was a problem hiding this comment. I'm not sure this is necessary. |
||
| switch t := v.(type) { | ||
| case nil: | ||
| return "", nil | ||
| case string: | ||
| return t, nil | ||
| } | ||
|
|
||
| return "", fmt.Errorf(errf, name, v, v) | ||
| } | ||
|
|
||
| func Bool(v any, name string) (bool, error) { | ||
|
|
||
| switch t := v.(type) { | ||
| case nil: | ||
| return false, nil | ||
| case bool: | ||
| return t, nil | ||
| case string: | ||
| return strconv.ParseBool(t) | ||
| } | ||
|
|
||
| return false, fmt.Errorf(errf, name, v, v) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These aren't assertions. These are format conversions.
jsonhelpersmaybe?