Thanks to visit codestin.com
Credit goes to github.com

Skip to content

core: add missing Builder interfaces #3363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented May 2, 2025

This PR adds missing Builder interfaces, allowing additional parameters to be added to requests.

@kayrus kayrus added the backport-v2 This PR will be backported to v2 label May 2, 2025
@github-actions github-actions bot added edit:networking This PR updates networking code edit:loadbalancer This PR updates loadbalancer code edit:compute This PR updates compute code edit:sharedfilesystems This PR updates sharedfilesystems code edit:blockstorage This PR updates blockstorage code edit:identity This PR updates identity code semver:major Breaking change labels May 2, 2025
@coveralls
Copy link

Coverage Status

coverage: 78.674%. first build
when pulling 1137240 on kayrus:opts-builder
into 0d5dccb on gophercloud:main.

@kayrus
Copy link
Contributor Author

kayrus commented May 2, 2025

Despite modifying function signatures, this PR can be backported to v2 since it adds an interface type and compatible with opts.

@kayrus
Copy link
Contributor Author

kayrus commented May 6, 2025

@stephenfin @pierreprinetti @mandre @EmilienM kindly ping

@stephenfin stephenfin merged commit d08ea79 into gophercloud:main May 7, 2025
58 of 65 checks passed
Copy link

github-actions bot commented May 7, 2025

Labels semver-major and semver-unknown block backports to the stable branch v2.

@kayrus kayrus deleted the opts-builder branch May 7, 2025 10:10
@kayrus kayrus added backport-v2 This PR will be backported to v2 and removed semver:major Breaking change backport-v2 This PR will be backported to v2 labels May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v2 This PR will be backported to v2 edit:blockstorage This PR updates blockstorage code edit:compute This PR updates compute code edit:identity This PR updates identity code edit:loadbalancer This PR updates loadbalancer code edit:networking This PR updates networking code edit:sharedfilesystems This PR updates sharedfilesystems code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants