Thanks to visit codestin.com
Credit goes to github.com

Skip to content

dns: implement shared zones list #3390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025
Merged

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented May 22, 2025

Fixes #3048

This PR adds zone share list and proper body read in the Share func. Previously this call leaked request bodies, because the response was not read.

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

https://docs.openstack.org/api-ref/dns/dns-api-v2-index.html#get-all-shared-zones

@kayrus kayrus added the backport-v2 This PR will be backported to v2 label May 22, 2025
@github-actions github-actions bot added edit:dns This PR updates dns code semver:major Breaking change labels May 22, 2025
@kayrus kayrus force-pushed the list-zone-share branch from 4871a11 to e628bfa Compare May 22, 2025 11:54
@kayrus kayrus added semver:minor Backwards-compatible change and removed semver:major Breaking change labels May 22, 2025
@github-actions github-actions bot added semver:major Breaking change and removed semver:minor Backwards-compatible change labels May 22, 2025
@kayrus
Copy link
Contributor Author

kayrus commented May 22, 2025

I'm removing semver:major since this PR fixes a bug, when the response body was not read.

@kayrus kayrus added semver:minor Backwards-compatible change and removed semver:major Breaking change labels May 22, 2025
@coveralls
Copy link

coveralls commented May 22, 2025

Coverage Status

coverage: 63.828% (-0.02%) from 63.844%
when pulling ef385c0 on kayrus:list-zone-share
into 6f0a5f6 on gophercloud:main.

@github-actions github-actions bot added edit:actions This PR updates GitHub Actions code edit:testinfra This PR updates testing infrastructure code and removed semver:minor Backwards-compatible change labels May 22, 2025
Copy link

Failed to assess the semver bump. See logs for details.

@kayrus kayrus added the semver:minor Backwards-compatible change label May 22, 2025
@kayrus kayrus force-pushed the list-zone-share branch 2 times, most recently from dc05078 to fd91aa8 Compare May 22, 2025 12:18
@github-actions github-actions bot removed the semver:minor Backwards-compatible change label May 22, 2025
Copy link

Failed to assess the semver bump. See logs for details.

Copy link

Failed to assess the semver bump. See logs for details.

@github-actions github-actions bot added the semver:major Breaking change label May 22, 2025
@kayrus kayrus force-pushed the list-zone-share branch from fd91aa8 to ea99ed5 Compare May 22, 2025 13:21
@github-actions github-actions bot added the edit:networking This PR updates networking code label May 22, 2025
@kayrus kayrus force-pushed the list-zone-share branch from ea99ed5 to 73ca181 Compare May 22, 2025 13:21
EmilienM
EmilienM previously approved these changes May 22, 2025
Copy link
Contributor

@EmilienM EmilienM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor suggestion feel free to skip it and merge.

@kayrus kayrus force-pushed the list-zone-share branch from 73ca181 to ef385c0 Compare May 22, 2025 14:09
@EmilienM EmilienM merged commit dbed7c1 into gophercloud:main May 22, 2025
19 of 21 checks passed
Copy link

Labels semver-major and semver-unknown block backports to the stable branch v2.

@kayrus kayrus deleted the list-zone-share branch May 22, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v2 This PR will be backported to v2 edit:actions This PR updates GitHub Actions code edit:dns This PR updates dns code edit:networking This PR updates networking code edit:testinfra This PR updates testing infrastructure code semver:major Breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Designate - Shared Zones
3 participants