-
Notifications
You must be signed in to change notification settings - Fork 557
dns: implement shared zones list #3390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm removing |
Failed to assess the semver bump. See logs for details. |
dc05078
to
fd91aa8
Compare
Failed to assess the semver bump. See logs for details. |
Failed to assess the semver bump. See logs for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor suggestion feel free to skip it and merge.
Labels |
Fixes #3048
This PR adds zone share list and proper body read in the
Share
func. Previously this call leaked request bodies, because the response was not read.Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://docs.openstack.org/api-ref/dns/dns-api-v2-index.html#get-all-shared-zones