Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[v2] Adjust List func to accept a Builder in tenants, routers and security groups packages #3397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented May 23, 2025

Manual Backport: #3097

This is a follow-up for the #3070

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

[PUT URLS HERE]

@github-actions github-actions bot added edit:networking This PR updates networking code v2 This PR targets v2 edit:identity This PR updates identity code semver:major Breaking change labels May 23, 2025
@coveralls
Copy link

Coverage Status

coverage: 63.672% (-0.003%) from 63.675%
when pulling cece9a4 on kayrus:secgroup_listoptsbuilder-v2
into 48faa0f on gophercloud:v2.

@kayrus kayrus requested a review from stephenfin May 23, 2025 15:20
Copy link
Contributor

@stephenfin stephenfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted previously at #3375 (comment), this is flagged as a major API change but isn't actually. Tests are happy. LGTM.

@stephenfin stephenfin merged commit ac09823 into gophercloud:v2 May 23, 2025
19 checks passed
@kayrus kayrus deleted the secgroup_listoptsbuilder-v2 branch May 23, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
edit:identity This PR updates identity code edit:networking This PR updates networking code semver:major Breaking change v2 This PR targets v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants