Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix documentation for gateway_ip in subnet update #3421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

mandre
Copy link
Contributor

@mandre mandre commented Jun 12, 2025

The neutron documentation was wrong, and not providing a gateway_ip is a no-op for subnet update.

Neutron docs being fixed at [1].

[1] https://review.opendev.org/c/openstack/neutron-lib/+/952428

@github-actions github-actions bot added the edit:networking This PR updates networking code label Jun 12, 2025
@github-actions github-actions bot added semver:patch No API change backport-v2 This PR will be backported to v2 labels Jun 12, 2025
stephenfin
stephenfin previously approved these changes Jun 12, 2025
Copy link
Contributor

@stephenfin stephenfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failures are unrelated so this lgtm

The neutron documentation was wrong, and not providing a gateway_ip is
a no-op for subnet update.

Neutron docs being fixed at [1].

[1] https://review.opendev.org/c/openstack/neutron-lib/+/952428
@pierreprinetti pierreprinetti merged commit 611b2a4 into gophercloud:main Jun 12, 2025
14 of 18 checks passed
@pierreprinetti pierreprinetti deleted the fix-subnet-update-docs branch June 12, 2025 14:17
@pierreprinetti pierreprinetti added the backport-v1 This PR will be backported to v1 label Jun 12, 2025
@coveralls
Copy link

coveralls commented Jun 12, 2025

Coverage Status

coverage: 63.628%. remained the same
when pulling e8982ca on shiftstack:fix-subnet-update-docs
into 800e8d5 on gophercloud:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v1 This PR will be backported to v1 backport-v2 This PR will be backported to v2 edit:networking This PR updates networking code semver:patch No API change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants