Improve Mac OS (darwin) support. #1024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes in this commit ensure that we can at least build supported standard library packages with GOOS=darwin. In theory, GOOS shouldn't even matter, since we always target the same platform (nodejs or browser), but for historical reasons, it does matter and we need to take extra steps to make it work. See gopherjs#693 for more details.
flimzy
approved these changes
May 3, 2021
|
Still having trouble with this. Pulled down Cannot find any references to these calls in my tree, so it may be pulling down an older tag? How do I test this? |
|
Figured it out after reading through the build process. I had to regenerate the VFS used to hold the syscall header files, using Should we be regenerating these as part of this PR? |
|
Oops, my bad. fb464eb has the updated VFS. Thanks for letting me know :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this commit ensure that we can at least build supported
standard library packages with GOOS=darwin. In theory, GOOS shouldn't
even matter, since we always target the same platform (nodejs or
browser), but for historical reasons, it does matter and we need to take
extra steps to make it work.
See #693 for more details.
Changes tested with
GOOS=darwin gopherjs build --minify -v $(go list std | grep -v -x -f .std_test_pkg_exclusions | grep -v -E "(vendor|internal)" | sort). Unfortunately, I don't have access to an Mac OS machine to run actual test… Ideally we should set up CI to do that.Fixes #1023.