Correctly handle built-ins and js.Object methods with go keyword.
#1090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
387387a to
841d55f
Compare
flimzy
reviewed
Dec 16, 2021
flimzy
reviewed
Dec 16, 2021
flimzy
approved these changes
Dec 16, 2021
- Adjust formatting to make it easier for an eye to find different
sections.
- Print go-syntax statement where the panic occurred in addition to
AST dump.
Built-ins and `js.Object` methods are represented by JS expressions that may not be straightforward function calls, or reference functions defined in the prelude. In such cases, the callable expression must be wrapped in a lambda. gopherjs#998 has fixed a similar issue for the `defer` keyword, and this change generalizes the same fix for the `go` keyword. Fixes gopherjs#547.
841d55f to
9356bc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built-ins and
js.Objectmethods are represented by JS expressions that may not be straightforward function calls, or reference functions defined in the prelude. In such cases, the callable expression must be wrapped in a lambda.#998 has fixed a similar issue for the
deferkeyword, and this change generalizes the same fix for thegokeyword.This change also contains a small improvement to the compiler panic message, which makes it easier to read at-a-glance.
Fixes #547.