Propagate blocking function information through function literal calls. #1115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a function literal is used that calls another function and that other function has yet to be analyzed, the call site for the function literal is not retained, so it's not processed later, so the function that was calling the function literal is not made blocking itself, when it should be. This change makes blocking status propagate through any number of intermediate literal function calls. This is a rebase of gopherjs#956. Fixes gopherjs#955. Co-authored-by: Frank Rehwinkel <[email protected]>
flimzy
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a function literal is used that calls another function and that other function has yet to be analyzed, the call site for the function literal is not retained, so it's not processed later, so the function that was calling the function literal is not made blocking itself, when it should be.
This change makes blocking status propagate through any number of intermediate literal function calls.
This is a rebase of #956 with additional regression tests.
Fixes #955.