Support .inc.js files for standard library overlays. #1119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4d483c1 to
3d82bcd
Compare
This will simplify access to low-level JavaScript features from the overlay sources. In many ways, this will fill the role of assembly in the upstream standard library. This change also introduces stricter checks for the ad-hoc build mode, requiring that all sources are in the same directory. This is necessary to maintain invariants about the build.Package we construct and is similar to what the go tool does.
flimzy
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will simplify access to low-level JavaScript features from the
overlay sources. In many ways, this will fill the role of assembly in
the upstream standard library.
This change also introduces stricter checks for the ad-hoc build mode,
requiring that all sources are in the same directory. This is necessary
to maintain invariants about the build.Package we construct and is
similar to what the go tool does.