Improve nodejs stack size limit heuristic.#1122
Merged
nevkontakte merged 1 commit intogopherjs:masterfrom Jun 13, 2022
Merged
Conversation
flimzy
reviewed
Jun 9, 2022
flimzy
approved these changes
Jun 9, 2022
Setting stack size exactly to the system limit will cause node to segfault before it has a chance to notice that it ran out of space. In my experiemnts values closer than 64 KiB may still cause a segfault from time to time. I also changed the multiplier to 1024, since that's what v8 actually uses for the flag value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting stack size exactly to the system limit will cause node to
segfault before it has a chance to notice that it ran out of space. In
my experiemnts values closer than 64 KiB may still cause a segfault from
time to time.
I also changed the multiplier to 1024, since that's what v8 actually
uses for the flag value.
Fixes #470.