Fix remaining standard library test failures #1125
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes following changes:
Callers()
andCaller()
now filter JS call stack to return something closer to what a program may expect under the upstream Go compiler.pc
number for a function call. Just the line isn't sufficient in minified mode, where the whole package code is one line. Together with the above, this fixest.Helper()
-related test failures in thetesting
package.low-level GC and heap details, inapplicable to GopherJS.
tests expect. Include original function names in the source map #1085 would
be a better long-term solution.
GopherJS.
After this PR
gopherjs_tests
CI workflow is green. For complete Go 1.18 support (aside from generics) we only need to fix several new failures in thegorepo_tests
workflow.Updates #1092.