Making syscall/js CSP compatible#1168
Merged
nevkontakte merged 5 commits intogopherjs:masterfrom Oct 25, 2022
Merged
Conversation
Contributor
Author
|
Tested locally with a simple client and server that does CSP. Throws an error like I expect on older versions of gopherjs. No error with these updates. |
nevkontakte
reviewed
Oct 24, 2022
Member
|
CI tests don't test for CSP compliance (obviously 🙃), but they do run the standard |
Contributor
Author
|
Have to log off for the evening and then I'm out of the office tomorrow, but will debug the failures Wednesday morning CDT. |
Contributor
Author
nevkontakte
approved these changes
Oct 25, 2022
Member
|
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Making the
syscall/jspackage compatible with a CSP that does not allowscript-src 'unsafe-eval'. See this thread for background.cc @nevkontakte can you merge this if you think it's good? I tested a CSP manually and it worked, put some snippets below.