Use go:embed for prelude JS snippets #1200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reference app: jQuery TodoMVC (
#outputSize |
This appears to be the result of different indentation as enforced by my editor when saving *.js files. We may want to alter this formatting, and add some eslint/prettier rules over time. |
|
Yeah, I'm not worried about size increase in the non-minified version, I doubt anyone uses it in production. I think adding a common prettier config would be a good thing to make sure that all contributors follow the same format. |
nevkontakte
approved these changes
Jun 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main advantage to this specific PR is that it allows for easier JS editor/IDE support when editing JS. As a follow-up, I'll work on eliminating the go:generate step for minification as well.