gofumpt the repo #1207
gofumpt the repo #1207
Conversation
This comment has been minimized.
This comment has been minimized.
|
It's completely open to discussion. I'm not fixated on gofumpt, although I do quite like it. And it will be enforced by the linter added in the other PR, if we choose to go this route. |
|
The only argument against gofumpt I can think of is that it increases barrier to entry for new contributors. Was that a problem in your other projects? |
|
It's never been a serious barrier, however I've also not used it on an active open source project before, either. |
|
Then I am open to giving it a shot, as long as we document it in https://github.com/gopherjs/gopherjs/wiki/Developer-Guidelines. We can always revert back to gofmt if we see people struggling. |
|
Reference app: jQuery TodoMVC (
#outputSize |
|
Merged, and wiki entry updated. |
This runs
gofumpton the entire repo. This is the default formatter I tend to use, and it was reformatting every file as I changed it. It seems cleaner to do it all in one fell swoop, assuming we agree to use this format.https://github.com/mvdan/gofumpt