Thanks to visit codestin.com
Credit goes to github.com

Skip to content

natives: duplicate aliasing.go in x/crypto revisted #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

benma
Copy link
Contributor

@benma benma commented Aug 28, 2023

Same as fcd349a.

x/crypto internally moved the AnyOverlap from
x/crypto/internal/subtle/ to /x/crypto/internal/alias/.

Same as fcd349a.

x/crypto internally moved the AnyOverlap from
x/crypto/internal/subtle/ to /x/crypto/internal/alias/.
benma added a commit to BitBoxSwiss/bitbox02-api-js that referenced this pull request Aug 28, 2023
```
cd gowrapper
go get github.com/digitalbitbox/bitbox02-api-go@8aaeb1fdf18ebf6a445f0b68582d9799f00b6793
go mod tidy
go mod vendor
```

The /x/crypto transitive dep was updated that broke GopherJS, so we
forked it to github.com/digitalbitbox/gopherjs and published the fix
at the tag `v1.17.2+go1.17.9-patched`. The patch is a backport of the
fix at gopherjs/gopherjs#1227.
@flimzy
Copy link
Member

flimzy commented Aug 30, 2023

I believe #1230 will resolve the CI failures, that are unrelated to the changes in this PR.

Copy link
Member

@nevkontakte nevkontakte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really ought to figure out a better strategy for handing this than cargo-culting this hack. One of those days...

@nevkontakte nevkontakte merged commit fbc70fe into gopherjs:master Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants